Sean Corfield <s...@corfield.org> writes:

>> The fact that the code currently sets the flag when opening the
>> connection is an implementation detail. It should not leak into the API
>
> On the contrary – it is important to identify the scope of the connection and 
> the scope of when auto-commit is on/off.

But why do you think it is okay to ignore the option I pass in? What is
wrong with setting the auto commit flag on an existing connection? 

>
> And you still haven’t answered my question about whether this code (without 
> with-db-connection) works now (with Beta 5):
>
> (into [] (take 2) (jdbc/query db query {:fetch-size 500 :auto-commit? false}))

Sorry, this one works. will test with reducible-query tomorrow.

-- 
Cheers
Ralf

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to