Hello Steve, I attached file predicates.patch for type and number predicates. Let me know, if this is an acceptable patch (I haven't worked with them before). We can then create an issue for Clojure-contrib if necessary.
Shawn, I keep wondering where is the best place to put tests for bug fixes. One way would be to create a separate file (bugs.clj) and put all these tests there. Another way is to include these tests into their respective categories - although I wonder for example test for (= () []) => true ... where should it go? Should it go equality.clj or to sequences.clj??? Any suggestions/opinions about where is the best place for bug fixes??? Thank you, Frantisek On Tue, Jan 27, 2009 at 2:05 AM, Stephen C. Gilardi <squee...@mac.com>wrote: > > On Jan 26, 2009, at 7:43 PM, Shawn Hoover wrote: > > I have a few tests in the works and am lacking commit access as well. > Should test contributions follow the procedure of group discussion, then > file an issue, then post a patch? If so, what would you like to know about > the patch(es)? > > > I consider the call for good unit tests covering areas of clojure or > contrib that currently lack them to be permanently open. > > One of the purposes of discussing things on the mailing list first is to > attract good ideas and thoughts from its denizens and avoid duplicating > large-ish bits of effort. You may even occasionally find a collaborator that > you can work with. That remains a good idea even in the case of unit tests. > Of course that's all best done when you are beginning to think about some > contribution rather than when it's nearly complete. > > Please do make a post here describing what you have. Then generate one or > more issues (in groupings that make good common sense) against > clojure-contrib describing which areas of clojure or contrib your > contribution will test and attach the patches to them. > > Thanks, > > --Steve > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en -~----------~----~----~----~------~----~------~--~---
predicates.patch
Description: Binary data
