On Fri, 27 Mar 2026 02:13:23 GMT, Sergey Bylokhov <[email protected]> wrote:

>> Matthias Baesken has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Small suggestions by David
>
> src/hotspot/os/aix/porting_aix.cpp line 330:
> 
>> 328:   info->dli_fname = ZEROSTRING;
>> 329:   info->dli_sname = ZEROSTRING;
>> 330:   info->dli_saddr = nullptr;
> 
> There seems to be a difference in how this struct is initialized here and in 
> awt: "ZEROSTRING" vs 0:
>>memset((void *)info, 0, sizeof(Dl_info));
> 
> I assume this is not an unexpected change for the code that uses Dl_info, but 
> it would be good to confirm.

Hi Sergey, from what I see on AIX the only usage of dladdr  in awt coding is 
here

https://github.com/openjdk/jdk/blob/22bbf900e18da9b31114ecb60d53f297870a29f4/src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c#L137

and this should work with both inits. (there is another usage of dladdr in 
XRBackendNative.c but this is not for AIX)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30295#discussion_r2999511474

Reply via email to