On Thu, 12 Mar 2026 14:51:59 GMT, Matthias Baesken <[email protected]> wrote:
> We use a struct DL_info on AIX (similar to the struct on Linux) to support > dladdr, but currently it is available 3 times (even in slightly different > versions). > This should be unified and put into a single header. A few remarks. Should get reviewed by build folks. make/modules/java.desktop/lib/AwtLibraries.gmk line 105: > 103: LIBAWT_CFLAGS += -I$(TOPDIR)/src/java.base/aix/native/include > 104: endif > 105: Should there be only one ifeq for aix? src/java.base/aix/native/include/dl_info.h line 2: > 1: /* > 2: * Copyright (c) 1996, 2026, Oracle and/or its affiliates. All rights > reserved. Add SAP Copyright? src/java.desktop/aix/native/libawt/porting_aix.h line 38: > 36: > 37: #ifdef __cplusplus > 38: extern "C" I think this header could be replaced completely (and also the implementation shared). Are you planning to do this separately in a new PR? ------------- PR Review: https://git.openjdk.org/jdk/pull/30220#pullrequestreview-3938360288 PR Review Comment: https://git.openjdk.org/jdk/pull/30220#discussion_r2926153551 PR Review Comment: https://git.openjdk.org/jdk/pull/30220#discussion_r2926158486 PR Review Comment: https://git.openjdk.org/jdk/pull/30220#discussion_r2926167730
