On Wed, 11 Mar 2026 19:50:29 GMT, Harshitha Onkar <[email protected]> wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 62:
>
>> 60: Point clkPoint;
>> 61: try {
>> 62: testRobot = new Robot();
>
> The following can be set in the beginning to avoid adding delays after each
> robot action.
>
>
> testRobot.setAutoWaitForIdle(true);
> testRobot.setAutoDelay(30);
added.
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 63:
>
>> 61: try {
>> 62: testRobot = new Robot();
>> 63: SwingUtilities.invokeAndWait((Runnable)
>> LastVisibleRow::createAndShowGUI);
>
> Runnable can be removed here and at other locations.
>
> Suggestion:
>
> SwingUtilities.invokeAndWait(LastVisibleRow::createAndShowGUI);
Updated.
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 75:
>
>> 73: resetMousePos();
>> 74: testRobot.delay(1000);
>> 75: testRobot.waitForIdle();
>
> A delay of 1s seems unnecessary after mouse move. Can be removed if auto
> delay is set in the beginning.
removed.
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 139:
>
>> 137:
>> 138: private static void resetMousePos() {
>> 139: testRobot.mouseMove(5, 5);
>
> It maybe a good idea to move it slightly farther from the edge
>
> Suggestion:
>
> testRobot.mouseMove(50, 50);
Updated.
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 168:
>
>> 166: captureRect[0] = new Rectangle(point.x+5, point.y+2,
>> 167: table.getColumnCount() * cellRect.width - 10,
>> 168: cellRect.height-2);
>
> Suggestion:
>
> captureRect[0] = new Rectangle(point.x + 5, point.y + 2,
> table.getColumnCount() * cellRect.width - 10,
> cellRect.height - 2);
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30177#discussion_r2923720918
PR Review Comment: https://git.openjdk.org/jdk/pull/30177#discussion_r2923719112
PR Review Comment: https://git.openjdk.org/jdk/pull/30177#discussion_r2923720292
PR Review Comment: https://git.openjdk.org/jdk/pull/30177#discussion_r2923721281
PR Review Comment: https://git.openjdk.org/jdk/pull/30177#discussion_r2923719469
