On Mon, 11 Aug 2025 15:51:05 GMT, Phil Race <p...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 42 commits: >> >> - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760 >> - Fix not needed background effect for Windows 10 >> - Remove Windows version check >> - Merge master >> - bullet/checkmark placement for varying imageicon size fix, test update >> - Adjust offset for varying size imageicon >> - squish fix >> - Alignment fix >> - MenuItem with icon fix >> - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760 >> - ... and 32 more: https://git.openjdk.org/jdk/compare/57553ca1...5f51ecdc > > src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line > 251: > >> 249: >> 250: public static void setAcceleratorSelectionForeground(Color >> acceleratorSelectionFg) { >> 251: acceleratorForeground = acceleratorSelectionFg; > > I just noticed this "oops". This should be acceleratorSelectionForeground. > Do we not have a test that would spot this ? Yes, you're right! I was curious why my IDE showed `acceleratorSelectionForeground` in grey as if unused. It's used but never assigned. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2267330854
