On Mon, 7 Jul 2025 03:07:08 GMT, Abhishek Kumar <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> L&F run as different test
>
> test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 44:
>
>> 42: * @build PassFailJFrame
>> 43: * @run main/manual RightLeftOrientation motif
>> 44: */
>
> Test can be extended for "Nimbus" L&F also as it is supported for all
> platforms.
Test enhancement can be done in separate PR..even it can be extended for other
platforms..but this PR only caters to the problem at hand..
> test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 86:
>
>> 84:
>> 85: The menu is divided into two halves. The upper half is oriented
>> 86: left-to-right and the lower half is oriented right-to-left.
>
> Is it better ?
>
> Suggestion:
>
> The menu is divided into two halves. The upper half is
> left-to-right oriented and the lower half is right-to-left oriented.
guess it's same..
> test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 113:
>
>> 111: System.out.println("Test for LookAndFeel " + lafClassName);
>> 112: PassFailJFrame.builder()
>> 113: .title("RightLeftOrientation Instructions")
>
> Setting title explicitly is not required.
ok
> test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 119:
>
>> 117: .build()
>> 118: .awaitAndCheck();
>> 119: System.out.println("Test passed for LookAndFeel " +
>> lafClassName);
>
> jtr file is available for each L&F testing and by default "Test Passed!"
> output is available. This doesn't seem to be useful.
>
> Test for LookAndFeel javax.swing.plaf.metal.MetalLookAndFeel
> Test passed!
> Test passed for LookAndFeel javax.swing.plaf.metal.MetalLookAndFeel
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25907#discussion_r2188973831
PR Review Comment: https://git.openjdk.org/jdk/pull/25907#discussion_r2188974203
PR Review Comment: https://git.openjdk.org/jdk/pull/25907#discussion_r2188972789
PR Review Comment: https://git.openjdk.org/jdk/pull/25907#discussion_r2188974386
