On Wed, 23 Apr 2025 22:16:54 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use ProcessTools
>
> test/jdk/java/awt/Clipboard/LostOwnershipChainTest/SystemClipboard2ProcTest.java
> line 117:
>
>> 115: OutputAnalyzer outputAnalyzer = new OutputAnalyzer(process);
>> 116:
>> 117: if (!process.waitFor(15, TimeUnit.SECONDS)) {
>
> In case of error it will be good to kill the child process via
> destroyForcibly(), or you can use
> `OputAnalyzer executeTestJava(String... command)`
> which will create the builder, then waits till completion and kill child
> process in case of errors.
I prefer an early timeout, but `ProcessTools.executeProcess()` doesn't allow to
set it, so `destroyForcibly()` was added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24806#discussion_r2056942873
