On Fri, 18 Apr 2025 23:21:05 GMT, Alisen Chung <[email protected]> wrote:
>> Updating and opening some JTable bugs
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update test instructions, add manual tag, move frame disposal into edt,
> volatile keyword
test/jdk/javax/swing/JTable/bug4190222.java line 61:
> 59:
> 60: SwingUtilities.invokeAndWait(() -> {
> 61: preResize = tbl.getSize();
If you do all the sizes retrieval inside the single invokeAndWait block you can
also do a comparison here and throw an exception if sizes mismatch. This way
you only need one variable preResize and you can do comparison as
`if (!preResize.equals(tbl.getSize()) ...` so you will only need only one local
variable. It is not critical but looks cleaner.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24739#discussion_r2052821780
