On Fri, 11 Apr 2025 06:37:58 GMT, Alexander Zvegintsev <[email protected]>
wrote:
> Few scroll bar tests are open sourced. Testing looks good.
LGTM apart from minor suggestions
test/jdk/java/awt/Scrollbar/ListScrollbarTest.java line 27:
> 25: * @test
> 26: * @bug 4029465
> 27: * @summary Win95 Multiselect List doesn't display scrollbar
Suggestion:
* @summary Win Multiselect List doesn't display scrollbar
test/jdk/java/awt/Scrollbar/ListScrollbarTest.java line 93:
> 91: private static void scrollbarCheck(Point point, boolean
> isScrollbarExpected) {
> 92: Color pixelColor = robot.getPixelColor(point.x, point.y);
> 93: boolean areColorsSimilar = areColorsSimilar(BG_COLOR, pixelColor,
> 5);
Mino : tolerance can be declared as static final var
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24590#pullrequestreview-2760974722
PR Review Comment: https://git.openjdk.org/jdk/pull/24590#discussion_r2039934730
PR Review Comment: https://git.openjdk.org/jdk/pull/24590#discussion_r2039937362
