On Tue, 8 Apr 2025 09:41:30 GMT, Tejesh R <[email protected]> wrote:
>> Harshitha Onkar has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - JOptionPane changes
>> - review changes
>
> test/jdk/javax/swing/JFileChooser/bug4464774.java line 67:
>
>> 65:
>> 66: public static JPanel createAndShowUI() {
>> 67: JButton button = new JButton("Show JFileChooser");
>
> I guess we can minimize button clicks, instead of showing JFileChooser on
> button we can directly show JFileChooser on a Frame right ? I hope there are
> no dependency on JButton click and this test?
> (same for other applicable test)
I went with the old UI but putting jfc in a frame is cleaner. Updated.
> test/jdk/javax/swing/JFileChooser/bug4522756.java line 58:
>
>> 56: .title("Instructions")
>> 57: .instructions(INSTRUCTIONS)
>> 58: .rows(12)
>
> I hope `row` setting is not required?
Added for Windows LAF.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2034131996
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2034132869
