On Tue, 4 Mar 2025 07:45:42 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Test fails in ubuntu OCI system..Made it more robust my adding
>> waitForIdle/delay before commencing test..
>> OCI system is ok with the fix.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add summary
Looks good to me…
…except for a few comments.
test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 1:
> 1: /*
Could you remove unused imports? There are 5 unused imports.
test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 58:
> 56: try {
> 57: robot = new Robot();
> 58: SwingUtilities.invokeAndWait(() -> createAndShowGUI());
Suggestion:
SwingUtilities.invokeAndWait(bug4213634::createAndShowGUI);
);
A method reference can be used.
test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 88:
> 86: private static void test() throws Exception {
> 87:
> 88: Util.hitMnemonics(robot, KeyEvent.VK_1);
Suggestion:
private static void test() throws Exception {
Util.hitMnemonics(robot, KeyEvent.VK_1);
The blank line at the start of a method is redundant and may be removed safely.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23837#pullrequestreview-2657733751
PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1979541520
PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1979549853
PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1979545492
