On Fri, 28 Feb 2025 08:50:31 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
> Test fails in ubuntu OCI system..Made it more robust my adding
> waitForIdle/delay before commencing test..
> OCI system is ok with the fix.
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 65:
> 63:
> 64: public static void createAndShowGUI() {
> 65: frame = new JFrame("TEST");
Could you use a more specific title?
test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 88:
> 86: SwingUtilities.invokeAndWait(() -> {
> 87: frame.dispose();
> 88: if (!menu.isSelected()) {
Previously, the condition `!menu.isSelected()` was verified before the frame
was disposed of.
I think you should verify whether menu is select before disposing of the frame;
once the frame is disposed of, the state of components is not well-defined.
-------------
PR Review: https://git.openjdk.org/jdk/pull/23837#pullrequestreview-2651432599
PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1975805598
PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1975816414
