On Tue, 25 Feb 2025 15:57:38 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> NoResizeEventOnDMChangeTest update
>
> test/jdk/java/awt/FullScreen/NoResizeEventOnDMChangeTest/NoResizeEventOnDMChangeTest.java
> line 60:
>
>> 58:
>> 59: public static void main(String[] args) {
>> 60: if (Platform.isOnWayland() && getGnomeShellMajorVersion() < 43) {
>
> Do you think this might be easier to read if the method is changed to
> `isFixDelivered` or something similar? I think if it would detect the version
> and compare it inside and just output true or false. This would also remove
> the version 1000 if there is no gnome-shell installed on the system, which
> is a bit confusing imo
Sure, updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23774#discussion_r1970150005
