On Fri, 7 Feb 2025 22:20:26 GMT, Harshitha Onkar <[email protected]> wrote:
>> FileDialogIconTest.java has been updated.
>>
>> Following changes were made.
>>
>> - Test instructions updated
>> - BugID associated with the test is updated to the correct one
>> - setIconBufferedImagesToFrame and setIconBufferedImagesToDialog btns added
>> to the frame.
>> - other minor cleanups
>
> Harshitha Onkar has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor
test/jdk/java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java line 44:
> 42: * @bug 6425126
> 43: * @summary Test to verify that PIT File Dialog icon not matching with
> 44: * the new java icon (frame Icon) - PIT build
I believe the File Dialog icon should match with the new java icon is correct
behaviour. So, isn't it better to remove **not** from the summary?
test/jdk/java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java line 152:
> 150: image =
> Toolkit.getDefaultToolkit().getImage(fileName);
> 151: PassFailJFrame.log("Loaded image " + "T" + i +
> ".gif."
> 152: + " Setting to the list for
> frame");
Suggestion:
PassFailJFrame.log("Loaded image T" + i + ".gif."
+ " Setting to the list for frame");
test/jdk/java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java line 172:
> 170: image =
> Toolkit.getDefaultToolkit().getImage(fileName);
> 171: PassFailJFrame.log("Loaded image " + "T" + i +
> ".gif."
> 172: + " Setting to the list for
> dialog");
Suggestion:
PassFailJFrame.log("Loaded image T" + i + ".gif."
+ " Setting to the list for dialog");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23523#discussion_r1948497099
PR Review Comment: https://git.openjdk.org/jdk/pull/23523#discussion_r1948492785
PR Review Comment: https://git.openjdk.org/jdk/pull/23523#discussion_r1948492998
