On Tue, 28 Jan 2025 10:40:40 GMT, Naveen Narayanan <[email protected]> wrote:
>> This contains test fixes for the following issue in
>> ScreenCaptureRobotTest.java
>>
>> • Failures in Mac OS because of mouse pointer visible on top of the image
>> that is screen captured by robot.
>>
>> Testing:
>> Tested using Mach5(100 times per platform) in MacOS, Linux, Windows & MacOS
>> AArch64. Seen all tests passing.
>
> Naveen Narayanan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344581: java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
Looks good to me.
There's a minor nit: a missing space after the comma in `mouseMove`.
test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 110:
> 108: private static void doTest() throws Exception {
> 109: Robot robot = new Robot();
> 110: robot.mouseMove(0,0);
Suggestion:
robot.mouseMove(0, 0);
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23264#pullrequestreview-2583688144
PR Review Comment: https://git.openjdk.org/jdk/pull/23264#discussion_r1935482257
