On Fri, 18 Oct 2024 22:36:33 GMT, Sergey Bylokhov <[email protected]> wrote:
>> This test follows the same pattern that I used in >> https://github.com/openjdk/jdk/pull/21474: >> >> https://github.com/openjdk/jdk/pull/21474/files#diff-2a8cee50408407d7e24de4cb85f0921cfc5db7c215d3b29cf101a4050323e9a9R92 > >> To ensure all the events in the queue are handled, I added >> `robot.waitForIdle()`. > > This will flush events which were posted after the windows gained focus, but > before the patch the test flushed all events (including event to show the > window which might be asynchronous). My point is that this operation might be > longer that 1 second(one of the reason we have all that deleyas). So we > should waitForIdle first, then wait via delay or other sync_ops. > @mrserb Are any more concerns with the updated code in > `JButton/bug4323121.java`? @mrserb Is there anything else you've got concerns about? If not, I'll integrate the PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21475#discussion_r1866479254
