On Tue, 5 Nov 2024 23:16:01 GMT, Daniel Gredler <[email protected]> wrote:
>> There are multiple issue with this test case
>> 1) Parser error due to yesno in @run main/manual=yesno
>> 2) User can only compare the UI rendering and compare with the print out.
>> User can't mark the test as pass or fail due to pass or fail buttons are
>> missing.
>> 3) When the test is executed using jtreg after user click on the print
>> button on the print dialog the whole test UIs ( frames) gets dispose and
>> user cannot compare the printout with the UI. But this works as expected in
>> test is running individually using java PrintTextTest
>
> Daniel Gredler has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use constants in switch, update problem list
test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 289:
> 287: Graphics2D g2d = (Graphics2D)g;
> 288: g2d.translate(pf.getImageableX(), pf.getImageableY());
> 289: g.drawString(page+" "+orient(pf),50,20);
Suggestion:
g2d.translate(pf.getImageableX(), pf.getImageableY());
g.drawString(page + " " + orient(pf), 50, 20);
test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 410:
> 408: s = "TextLayout 1: \u0924\u094d\u0930
> \u0915\u0948\u0930\u0947 End.";
> 409: TextLayout tl = new TextLayout(s, new HashMap<>(), frc);
> 410: tl.draw(g2d, ix, iy);
Suggestion:
tl.draw(g2d, ix, iy);
test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 415:
> 413: s = "TextLayout 2: \u0924\u094d\u0930
> \u0915\u0948\u0930\u0947 End.";
> 414: tl = new TextLayout(s, f, frc);
> 415: tl.draw(g2d, ix, iy);
Suggestion:
tl.draw(g2d, ix, iy);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1831582601
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1831583028
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1831583213
