On Tue, 15 Oct 2024 22:39:09 GMT, Alisen Chung <[email protected]> wrote:
>> At first, I noticed bug4490179.java didn't release mouse button 1, which >> could affect the following tests. >> >> I started looking at the test and updated it to use `CountDownLatch` instead >> of delays. >> >> @azvegint handled releasing mouse button 1 in >> https://github.com/openjdk/jdk/pull/19339#discussion_r1609201116. >> >> The updated version first verifies `mouseButton3Released` event is received >> and ensures `actionPerformed` is not received at this time. >> >> Then mouse button is released; this should trigger two events: >> `mouseButton1Released` and `actionPerformed`. It is verified that these >> events are received. >> >> I kept debugging prints, they help understanding which actions lead to which >> events. >> >> The updated test reproduces the original, it is easily verified using Java >> 8; the updated test is stable in CI. >> >> >> The `javax/swing/JButton/bug4490179.java` test is also modified in >> https://github.com/openjdk/jdk/pull/20861, @mrserb, could you take a look? I >> was going to suggested factoring out the changes to this test from #20861, >> yet I modified it myself. I realised it when I started creating the PR. > > test/jdk/javax/swing/JButton/bug4490179.java line 58: > >> 56: private static volatile Point buttonCenter; >> 57: >> 58: private static final CountDownLatch windowGainedFocus = new >> CountDownLatch(1); > > line here is too long and probably should be put in 2 lines I don't it should, it's 86 column long, it fits nearly well; I don't think wrapping the line improves readability or clarity. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21474#discussion_r1804370397
