On Fri, 11 Oct 2024 18:31:12 GMT, Phil Race <[email protected]> wrote:
>> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/Canvas/MultiDitherTest.java line 77: > >> 75: String INSTRUCTIONS = """ >> 76: This test displays several dithered Canvases similar to >> the >> 77: DitherTest demo applet, one for each available >> GraphicsConfiguration. > > remove the phrase "similar to the DitherTest demo applet" that applet was > retired many years ago. Removed the phrase. > test/jdk/java/awt/Canvas/MultiDitherTest.java line 84: > >> 82: On Solaris, making some Windows active will cause some >> of the >> 83: other Windows to display strangely. This is normal. >> 84: Ensure that there are as many Frames created as there are > > remove the sentence about Solaris, it hasn't been a supported platform for > several years Removed. > test/jdk/java/awt/Canvas/MultiGraphicsTest.java line 68: > >> 66: Ensure that there are as many Windows created as there >> are >> 67: available GraphicsConfigurations. >> 68: Examine each Window to ensure it displays Jim. > > Jim ? You mean Duke. > > Also remove mention of Solaris, it hasn't been a supported platform for > several years Updated. > test/jdk/java/awt/Rectangle/IntersectionTest.java line 30: > >> 28: * @summary Test to verify setClip with invalid rect changes rect to >> valid >> 29: * @library /java/awt/regtesthelpers >> 30: * @build PassFailJFrame > > This isn't a manual test, it does not need these two lines Updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1798766995 PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1798767063 PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1798767110 PR Review Comment: https://git.openjdk.org/jdk/pull/21464#discussion_r1798766915
