On Wed, 9 Oct 2024 09:28:40 GMT, Tejesh R <[email protected]> wrote:
>> Open source these AWT Dialog tests:
>>
>> java/awt/Dialog/FileDialogGetFileTest.java
>> java/awt/Dialog/EnabledResetTest.java
>> java/awt/Dialog/ChoiceModalDialogTest.java
>> java/awt/Dialog/DialogBackgroundTest.java
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated review comments
Changes requested by honkar (Reviewer).
test/jdk/java/awt/Dialog/ChoiceModalDialogTest.java line 134:
> 132: if (!mouseOK || !keyOK) {
> 133: throw new RuntimeException("Test FAILED");
> 134: }
This check can be moved before finally block and the test failure msg can be
more descriptive.
If you are converting into CountDownLatch then you need to change this check
accordingly
test/jdk/java/awt/Dialog/ChoiceModalDialogTest.java line 136:
> 134: }
> 135:
> 136: System.out.println("Test Passed!");
`System.out.println("Test Passed!");` is redundant and can be removed.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21404#pullrequestreview-2357722326
PR Review Comment: https://git.openjdk.org/jdk/pull/21404#discussion_r1793869156
PR Review Comment: https://git.openjdk.org/jdk/pull/21404#discussion_r1793866465
