On Tue, 8 Oct 2024 22:33:48 GMT, Harshitha Onkar <[email protected]> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java line 65:
>
>> 63: Frame f = new Frame("Click Here!");
>> 64:
>> 65: Label l = new Label("" + counter);
>
> Adding a label to counter seems good.
>
> Suggestion:
>
> Label l = new Label("Counter" + counter);
I initially added it, but removed it when iterating to keep it closer to the
original. But, I agree. Re-added.
> test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java line 90:
>
>> 88: return;
>> 89: }
>> 90: }
>
> This is a busy wait loop, maybe there is a better way of doing it, although
> it might be out-of-scope for this PR changes.
I'll leave it for a future PR if needed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21398#discussion_r1792619410
PR Review Comment: https://git.openjdk.org/jdk/pull/21398#discussion_r1792619622
