On Mon, 7 Oct 2024 21:35:42 GMT, Andy Goryachev <[email protected]> wrote:
> is this a good idea to write files? e.g. the CI system may not make the files > accessible, the local FS might overflow, etc. > > there is an idea to output base-64 encoded image to the stdout, see > https://bugs.openjdk.org/browse/JDK-8328716 this way > > * the images will be available as long as the log file is available > * zero dependency on local file system or its limitations It is perfectly fine. We do this in many tests. jtreg ensures that CWD is the working directory of the test. it will thus be preserved along with the rest of the files jtreg preserves. And saving as .png lets you look at it without more hassle. OTOH I don't think it necessary to print the absolute path. Often that's on a test system you don't get to see. Instead you just get to downlaod the results and the absolute path is not a good idea then. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20993#discussion_r1790922568
