On Thu, 25 Jul 2024 04:01:03 GMT, Abhishek Kumar <[email protected]> wrote:
>> In GTKPainter.paintPopupMenuBackground method, `img != null` condition will >> always be true, because it's only checked after `img.getRGB` method is >> called and that means img can't be `null`. So, the null check condition is >> removed. CI testing is ok. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment fix > Also the comment that it is done for Adwaita theme, shouldn't then this code > block be done in native after checking what theme is effective now, as this > may affect Yaru or other theme potentially, no? Ran the test mentioned in [JDK-8160160](https://bugs.openjdk.org/browse/JDK-8160160) and observed the same issue for Yaru theme as well where border is not drawn if this part of code is commented. So, I think the effect should be same for Adwaita, Yaru and other themes. Adwaita_No_Border  Yaru_No_Border  Adwaita_With_Border  Yaru_With_Border  However I am unable to run the JCK test with the option `-server -d64 -Xmixed` mentioned in [JDK-8160160](https://bugs.openjdk.org/browse/JDK-8160160). ------------- PR Comment: https://git.openjdk.org/jdk/pull/20308#issuecomment-2249355593
