On Wed, 10 Jul 2024 05:56:17 GMT, Abhishek Kumar <[email protected]> wrote:
> This test was modified under > [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the > applet usage. Test modification includes the instruction change as well which > says that `Check that there is a panel with "Text Preview Panel" text and > with title "Preview" in the JColorChooser`. Applet test didn't say explicitly > about the panel title. > > When the test is run with `GTKLookAndFeel` option, `Preview` title is missing > due to the `showPreviewPanelText` property defined for `GTKLookAndFeel` is > set to **FALSE**. `showPreviewPanelText` property is not defined for other > L&Fs and that leads to fallback to the default value of **TRUE** for the > property while lookup. > > Proposed fix is to change the default value of `showPreviewPanelText` > property to **TRUE** for GTK L&F. Are there no repercussions to setting this boolean to `TRUE` across the board for one test to pass? I guess my question is, why was it explicitly set to `FALSE` before and now we set it to `TRUE`? Is there a native example? And is this a harmless change? ------------- PR Review: https://git.openjdk.org/jdk/pull/20104#pullrequestreview-2181183504
