On Tue, 2 Apr 2024 12:50:33 GMT, Alexey Ivanov <[email protected]> wrote:
>> Please review this PR that removes unused functions, variables, and WM_AWT
>> window messages.
>>
>> The unused code was detected by automated analysis (MSVC compiler and
>> linker, CodeQL analyzer). I manually verified every symbol before removing.
>> Mach5 client libs testing clean.
>>
>> Some WM_AWT messages have different IDs after this change. The IDs have
>> changed a few times before, so I think this shouldn't be a problem.
>
> src/java.desktop/windows/native/libawt/windows/awt_Debug.cpp line 111:
>
>> 109: * DTRACE print callback to dump window's update region bounding
>> rectangle
>> 110: */
>> 111: void DumpUpdateRectangle(const char * file, int line, int argc, const
>> char * fmt, va_list arglist) {
>
> Can these functions be useful for debugging?
>
> Does it make sense to hide them unless `DEBUG` is defined?
they were `if defined(DEBUG)` already; I can keep them if you think it makes
sense.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18553#discussion_r1548244729
