On Tue, 10 May 2022 06:29:47 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> DamonGuy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed test summary. Added check for JButton.
>
> test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.java
> line 116:
>
>> 114: ImageIO.write(image, "png",
>> 115: new File(testDir + "/fail_image.png"));
>> 116: throw new RuntimeException("HTML image not centered in
>> button");
>
> overall looks ok. Only thing is during failure, it does not show for which
> L&F the test is failing since you are iterating for all L&Fs.
Sure, this can be changed. I can instead iterate through all L&F's and track
all failing L&F's in a buffer to be displayed in the runtime exception in the
end. How should the images be handled? Should I just generate X images where X
is the number of failed L&F's?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8407
