On Tue, 12 Apr 2022 04:15:56 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:

>> Alexey Ushakov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill
>>   
>>   Extracted try/catch logic of SurfaceData cast to particular SurfaceData 
>> subclass into convenience method SurfaceData.convertTo(). Applied the method 
>> to XRTextRenderer.drawGlyphList() and XRMaskFill.MaskFill(). Refactored 
>> try/catch blocks handling similar cases.
>
> I am on vacation this week. I will review this PR on priority next week.

> Looks fine, I suggest checking the fix via mach5. @aghaisas please take a 
> look.

The fix looks good. Also, the mach5 run is green with this change.
@avu, is it possible to add an automated test?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8015

Reply via email to