On Tue, 5 Apr 2022 20:16:28 GMT, lawrence.andrews <d...@openjdk.java.net> wrote:
>> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user can mark the test pass or fail >> 3) Upon failing the test user should be able to elaborate why the test >> failed and this can be added to the test failure. >> 4) Disposing of all the frames. >> >> @aivanov-jdk > > lawrence.andrews has updated the pull request incrementally with one > additional commit since the last revision: > > Fixed review comments test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 85: > 83: frame.dispose(); > 84: } > 85: }); I just thought whether it's feasible to keep a list of frames / windows to be disposed of inside the `PassFailJFrame` class. It disposes of its instruction frame when the wait is over, it can handle disposing of other frames too. If I remember correctly, the first version disposed of of all windows. If we make it an explicit list, it shouldn't cause issues. ------------- PR: https://git.openjdk.java.net/jdk/pull/7966
