On Wed, 23 Feb 2022 21:34:29 GMT, Emmanuel Bourg <d...@openjdk.java.net> wrote:

>> Emmanuel Bourg has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - Test case for the window icon update on DPI change (Java generic font 
>> names are usually capitalized)
>>  - Test case for the window icon update on DPI change (dispose the frame 
>> after a timeout on the EDT)
>
> Just tested on macOS 12 with a non Retina screen and OpenJDK 8: the icon 
> displayed in the dock when the test frame is minimized is the 32x32 one. If I 
> add more icons to the list, it picks the biggest one, up to 128x128. Bigger 
> icons are ignored.
> 
> The issue observed on Windows doesn't really transpose to macOS, I think I'll 
> revert the change to `LWWindowPeer`.

> @ebourg @aivanov-jdk are the remaining issues test issues, or might there 
> still be product issues ? No pressure to push but let's not forget about it 
> either.

Windows side looks reasonable to me. The window updates the icon when it's 
dragged from one monitor to another with different scale.

macOS changes have been reverted.

I couldn't see the icon updates on Linux. Should the changes for Linux be 
reverted too?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6180

Reply via email to