On Fri, 29 Oct 2021 19:54:47 GMT, Alisen Chung <[email protected]> wrote:
> Added more time to test, removed pixel check during EmbeddedFrame test from
> OverlappingTestBase.
The bug says
This test just need more time to go.
Provided JDK-8158801 is fixed.
but that bug isn't fixed ..
test/jdk/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java line 145:
> 143: }
> 144:
> 145: if(currentAwtControl == null) { System.out.println("t"); }
Is this a left over debugging statement ?
test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 359:
> 357: private static boolean isValidForPixelCheck(Component component) {
> 358: if ((component instanceof java.awt.Scrollbar)
> 359: || (isMac && ((component instanceof java.awt.Button) ||
> (component == null)))) {
"removed pixel check during EmbeddedFrame test from OverlappingTestBase."
Well you presumably can't pixel check a null component, but why is it null ?
It seems like a test issue for it to be null. Can you explain how this happens ?
Also if this code *were* to stay it would be better formatted like
if ((component instanceof java.awt.Scrollbar) ||
(isMac && ((component instanceof java.awt.Button) ||
(component == null))))
{
-------------
PR: https://git.openjdk.java.net/jdk/pull/6177
