On Tue, 21 Sep 2021 08:13:41 GMT, Pankaj Bansal <[email protected]> wrote:
>> Problem : >> 1) Testcase was failing due to parse exception yesno >> 2) After removing yesno tag test frame and immediately get disposed >> >> Fix : >> 1) Removed yesno tag >> 2) Show the test frame with pass, fail button. Now user can click on the >> `print' button to show the print dialog and take the print out and compare >> the print with the graphics rendered on the frame. Click either on the >> 'Pass' or 'Fail' button to make the pass or fail also clicking the 'Pass' or >> 'Fail' closes the test frame. >> 3) Added the timeout If not interaction is performed on the test frame. >> >> @shurymury > > test/jdk/java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java line 83: > >> 81: import static java.awt.image.BufferedImage.TYPE_INT_RGB; >> 82: import static java.awt.image.BufferedImage.TYPE_USHORT_555_RGB; >> 83: import static java.awt.image.BufferedImage.TYPE_USHORT_GRAY; > > Thats lot of static imports from just two classes. This just looks weird. Is > it recommended practice to do? I am not saying this is wrong as you are > removing wild card imports, but it just does not look good to have so many > statement for importing from two classes. In most of the test cases wild card is removed and its replaced with each class import statement. ------------- PR: https://git.openjdk.java.net/jdk/pull/5595
