Hi Mark,
Unfortunately, I can't change CLAMAVUSER to CLAMAV_USER in the .in files in
0.103 because it will break things with Autotools. I could change it to use
CLAMAVUSER as you suggest, and update the documentation. But that doesn't feel
like a good solution either, since it will be different in 0.104.
So I'm inclined to leave these CMake issues in 0.103 on the grounds that CMake
was not ready or intended for production use in 0.103 and there are many other
issues with the CMake tooling in 0.103 that we can't easily backport.
But your fixes for 0.104 seem solid to me so I'll merge that PR now. Thanks
again for your help!
-Micah
Micah Snyder
ClamAV Development
Talos
Cisco Systems, Inc.
________________________________
From: Mark Fortescue <mark.li...@thurning-instruments.co.uk>
Sent: Thursday, August 5, 2021 3:09 AM
To: Micah Snyder (micasnyd) <micas...@cisco.com>; ClamAV users ML
<clamav-users@lists.clamav.net>
Subject: Re: PATCH[2]: Re: ClamAV® blog: ClamAV 0.104.0 Release Candidate is
here!
Hi Micah,
Having picked up on one set of unset substitution variables I cheated
and used 'find'. 'grep'. 'sed'. 'cut' and 'sort -u' to go through and
find all the substitution variables and check that they were set :).
Please note that the CLAMAV_USER changes or setting CLAMAVUSER in the
documentation are also needed for 0.103.x.
Regards
Mark.
On 05/08/2021 03:07, Micah Snyder (micasnyd) wrote:
> Thanks for patch #2. Very good eye catching the CLAMAV_USER and CONFDIR
> variable issues.
> I've updated the PR with the change:
> https://github.com/Cisco-Talos/clamav/pull/231
> <https://github.com/Cisco-Talos/clamav/pull/231>
>
> CMake: Fix build on systems lacking inttypes format string macros by
> micahsnyder · Pull Request #231 · Cisco-Talos/clamav
> <https://github.com/Cisco-Talos/clamav/pull/231>
> Define _SF64_PREFIX and _SF32_PREFIX on systems that do not have these
> macros: PRIu64, PRIx64, PRIi64, PRIu32, PRIi32, PRIx32 This logic is the
> same as in the previous build system, here: https://g...
> github.com
>
> If you see any problems please let me know. Else, if all goes well with
> testing on my side I'll merge it.
>
>
> Micah Snyder
> ClamAV Development
> Talos
> Cisco Systems, Inc.
> ------------------------------------------------------------------------
> *From:* Mark Fortescue <mark.li...@thurning-instruments.co.uk>
> *Sent:* Friday, July 30, 2021 6:36 AM
> *To:* Micah Snyder (micasnyd) <micas...@cisco.com>; ClamAV users ML
> <clamav-users@lists.clamav.net>
> *Subject:* PATCH[2]: Re: ClamAV® blog: ClamAV 0.104.0 Release Candidate
> is here!
> Hi Micah,
>
> Please find attached patch #2 to clean up patch #1 'if' statements and
> fix some other issues fond (mostly documentation).
>
> The outstanding variable is LIBCLAMAV_LIBS.
>
> It is used by clamav-config.in and libclamav.pc.in.
>
> Not sure about the logic required for this one. On my OS, it is set to
> '-lbz2' for autotools but I don't know why it is being set and no other
> dependent libraries are there.
>
> I would expect it to be a list of all dependent libraries used when
> linking with libclamav.
>
> Regards
> Mark.
>
> On 29/07/2021 00:54, Micah Snyder (micasnyd) wrote:
>> How's this? https://github.com/Cisco-Talos/clamav/pull/231
>>
>
> <snipped>
>
_______________________________________________
clamav-users mailing list
clamav-users@lists.clamav.net
https://lists.clamav.net/mailman/listinfo/clamav-users
Help us build a comprehensive ClamAV guide:
https://github.com/vrtadmin/clamav-faq
http://www.clamav.net/contact.html#ml
