Hi Arjen, The '-D ENABLE_UNRAR=OFF' test failure issue is definitely not expected! I think that one should be an easy enough fix.
If you're up for it, it would be helpful to add a GitHub issue for this bug: https://github.com/Cisco-Talos/clamav/issues I will make a note to add a test case in our custom tests pipeline for having UNRAR disabled. The other issue with iconv if also not expected. We haven't been testing with openSUSE. I think we should also add an openSUSE docker container to our CI pipeline. I gave it a try in a docker container just now on my laptop. For me it detected iconv as being in libc, but failed the libclamav unit tests with: 1: 99%: Checks: 1127, Failures: 4, Errors: 0 1: /clamav/unit_tests/check_clamav.c:1460:F:assorted functions:test_cli_codepage_to_utf8_jis:0: test_cli_codepage_to_utf8: Failed to convert CODEPAGE_JAPANESE_SHIFT_JIS to UTF8: ret != SUCCESS! 1: /clamav/unit_tests/check_clamav.c:1478:F:assorted functions:test_cli_codepage_to_utf8_utf16be_null_term:0: test_cli_codepage_to_utf8: Failed to convert CODEPAGE_UTF16_BE to UTF8: ret != SUCCESS! 1: /clamav/unit_tests/check_clamav.c:1496:F:assorted functions:test_cli_codepage_to_utf8_utf16be_no_null_term:0: test_cli_codepage_to_utf8: Failed to convert CODEPAGE_UTF16_BE to UTF8: ret != SUCCESS! 1: /clamav/unit_tests/check_clamav.c:1514:F:assorted functions:test_cli_codepage_to_utf8_utf16le:0: test_cli_codepage_to_utf8: Failed to convert CODEPAGE_UTF16_LE to UTF8: ret != SUCCESS! 1: NOTICE: Use the 'T' environment variable to adjust testcase timeout We used to have similar failures for Alpine but fixed those. If you can submit a second issue for this one as well, I would very much appreciate it. Regards, Micah > -----Original Message----- > From: clamav-users <clamav-users-boun...@lists.clamav.net> On Behalf Of > Arjen de Korte via clamav-users > Sent: Sunday, July 25, 2021 11:50 AM > To: ClamAV users ML <clamav-users@lists.clamav.net> > Cc: Arjen de Korte <build+cla...@de-korte.org> > Subject: Re: [clamav-users] ClamAV® blog: ClamAV 0.104.0 Release Candidate > is here! > > Citeren Arjen de Korte via clamav-users <clamav-users@lists.clamav.net>: > > > [ 6s] -- Performing Test Iconv_IS_BUILT_IN > > [ 6s] -- Performing Test Iconv_IS_BUILT_IN - Failed > > [ 6s] CMake Error at > > /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 > > (message): > > [ 6s] Could NOT find Iconv (missing: Iconv_LIBRARY) > > [ 6s] Call Stack (most recent call first): > > [ 6s] > > /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 > > (_FPHSA_FAILURE_MESSAGE) > > [ 6s] cmake/FindIconv.cmake:129 (find_package_handle_standard_args) > > [ 6s] CMakeLists.txt:332 (find_package) > > Apparently this test is not able to determine if iconv is actually built-in. > Adding > '-D Iconv_IS_BUILT_IN=ON' to the cmake command line, fixes this. If this is > the > intended behavior, it might be useful to change the error message (it took me > a > while to figure out that iconv was actually built-in). > > Another thing is that when adding '-D ENABLE_UNRAR=OFF' to the cmake > command line, one also has to set '-D ENABLE_TESTS=OFF', otherwise the build > will fail fairly quickly due to the following error. > > Error evaluating generator expression: > > $<TARGET_FILE_DIR:ClamAV::libunrar_iface> > > No target "ClamAV::libunrar_iface" > > errors. Not sure if this is expected though. > > Other than this, the build seems to succeed on openSUSE Tumbleweed and the > resulting binaries seem to run fine. > > > _______________________________________________ > > clamav-users mailing list > clamav-users@lists.clamav.net > https://lists.clamav.net/mailman/listinfo/clamav-users > > > Help us build a comprehensive ClamAV guide: > https://github.com/vrtadmin/clamav-faq > > http://www.clamav.net/contact.html#ml _______________________________________________ clamav-users mailing list clamav-users@lists.clamav.net https://lists.clamav.net/mailman/listinfo/clamav-users Help us build a comprehensive ClamAV guide: https://github.com/vrtadmin/clamav-faq http://www.clamav.net/contact.html#ml
