Dennis Peterson wrote:
> Ed Kasky wrote:
>
>    
>> I think I'm almost there...
>>
>> I figured out the init script but now the milter is having trouble
>> with the clamd socket.
>>
>>   From the milter log:
>> Sat Mar 21 13:42:02 2009 ->  +++ Started at Sat Mar 21 13:42:02 2009
>> Sat Mar 21 13:42:02 2009 ->  ERROR: Failed to parse ClamdSocket
>> directive '/var/run/clamav/clamd.sock'
>> Sat Mar 21 13:42:02 2009 ->  ERROR: Failed to init the socket pool
>>
>> srwxrwxrwx 1 clamav clamav 0 Mar 21 13:41 /var/run/clamav/clamd.sock
>>
>>   From clamd.conf:
>> LocalSocket /var/run/clamav/clamd.sock
>> FixStaleSocket yes
>> TCPSocket 3310
>> TCPAddr 127.0.0.1
>>
>>   From clamav-milter.conf:
>> User clamav
>> ClamdSocket /var/run/clamav/clamd.sock
>> ClamdSocket tcp:127.0.0.1:3310
>>
>>      
> Pardon a bit of thread hijacking but...
>
> Developers - could you unify the names of these sockets and invocation method?
>
>   From clamd.conf:
> LocalSocket /var/run/clamav/clamd.sock
> TCPSocket 3310
> TCPAddr 127.0.0.1
>
>   From clamav-milter.conf:
> ClamdSocket /var/run/clamav/clamd.sock (this is wrong, BTW)
> ClamdSocket tcp:127.0.0.1:3310
>    
I hope I have correctly interpreted your request; if I have, I like your 
idea. clamd.conf should accept multiple Listening socket lines (maybe 
with a Listen directive, which makes sense since other programs use this 
terminology). This might look like:
#clamd.conf:
Listen unix:/var/run/clamav/clamd.sock
Listen tcp:localhost:3310
Listen tcp:*:3333

#clamav-milter.conf:
ClamdSocket unix:/var/run/clamav/clamd.sock
ClamdSocket tcp:localhost:3310
ClamdSocket tcp:remotehost:3333

However, allowing multiple Listen directive would imply allowing 
listening on different ports and unix sockets, which might require {some 
code restructuring to allow this} or {new error messages such as ``only 
one tcp socket allowed'' and ``only one unix listen socket allowed''}. 
(English needs some standardized type of mathematical-style parenthesis 
operators to control the order of expansion of phrases connected by 
conjunctions :-). ). However, such a drastic change in config-file 
format would really bug some people who use or, rather, ``deploy'' clamd 
on many machines.

Does this idea deserve a feature request bug?

-- 
binki

_______________________________________________
Help us build a comprehensive ClamAV guide: visit http://wiki.clamav.net
http://www.clamav.net/support/ml

Reply via email to