On Wed, 7 Jun 2006 16:50:35 -0400 "Brian A. Reiter" <[EMAIL PROTECTED]> wrote:
> This patch for the shared argument parser will canonicalize Win32 paths > strings (eg. C:\foo\bar) to UNIX paths (eg. /dev/fs/C/foo/bar) on Interix. > This is important because Interix is the UNIX subsystem for Windows and as > such Interix binaries can interact with Windows binaries and the Windows > command shell. With this patch, clamscan can automagically make the > translation, which makes it easy to call from Windows programs that aren't > POSIX-aware. Hi Brian, I've reviewed your patches and have the following comments: - taking into account Interix is a bit exotic platform, the patches are quite large - the path translation code is doubled in clamd/scanner.c and clamscan/options.c, it should be moved to shared/misc.c as a general procedure - some changes are incorrect, especially those marked with (__GNUC__ >= 3): first of all, it's up to the configure to check if and how compiler handles structure packing and other features (there's already a code for that); secondly, your changes would result in broken code on some platforms (it's not enough to modify header files, a proper work-around must be also implemented in the code). Best regards, -- oo ..... Tomasz Kojm <[EMAIL PROTECTED]> (\/)\......... http://www.ClamAV.net/gpg/tkojm.gpg \..........._ 0DCA5A08407D5288279DB43454822DC8985A444B //\ /\ Mon Jun 19 18:50:25 CEST 2006
signature.asc
Description: PGP signature
_______________________________________________ http://lurker.clamav.net/list/clamav-devel.html
