> for(i=0; i<strlen(s); i++)... has quadratic run time.
> Not a problem in current code (it is never called on
> more than LINE_LENGTH (1024) bytes, thus touches 'only' 500 Kbytes at
> most), but it is not a good practice anyway. Especially since we don't need
> strlen() here _at all_.

I talked about this in a recent posting to other team members. Indeed I 
mentioned a solution which, not only removes any calls to strlen but needs no 
temporary variables at all (your "unsigned char c" is not needed).

So a fix is already "in the queue", but thanks anyway.

_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html

Reply via email to