Laurent Wacrenier wrote:

>> I'll use _PATH_BSHELL from <paths.h> instead -
>> 
>> http://jessen.ch/files/patch-clamav-0.83-freshclam-with-fork3
> 
> That's better, but this include is not standart and may not exists
> everywhere.

paths.h is from GNU libc.  

> In HPUX, the system() shell is /bin/posix/sh (or /usr/bin/sh on some
> versions) and path.h is not here.
> 
> In Solaris, the system() shell may be /usr/xpg4/bin/sh or /usr/bin/sh
> according the __EXTENSIONS__ macro. path.h is still not here.

If paths.h is not standard, perhaps it would be best to leave the decision
up to autoconf? 

My personal preference is to just not use it. That is, to effectively alter the 
behaviour 
of OnUpdateExecute.  It would mean it could only accept actual shell-scripts 
and 
executables, and not plain commandlines (with pipes and redirects etc.) 
execve() works with executables and scripts with #!/your/favourite/shell .

Is this too much of a change - I fully understand it'll cause some 
incompatibility, 
but since clamav is still at a 0.8x release, prehaps it is reasonable?


/Per Jessen, Zürich


_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html

Reply via email to