[EMAIL PROTECTED] wrote:
> I decided to enhance the wipe plugin to do vertical as well as horizonal
> wipes, and I've a few questions and issues about this code:
>
> - I really don't like the indenting style of the existing code. Do I have
> to follow it, or can I switch to something more readable for the parts I
> write?
Favor use the existing style, when it comes to indenting, consistency is
the most important thing imo, the cinelerra source indenting is already
a mess but thats no reason to make it worse. (I would prefer another
style too)
> - We have a class called "BC_Radial" for radio buttons. It's probably too
> late to change it, but that certainly doesn't help understandability of
> this code. Radio buttons are called that because they function like the
> station-selection buttons on some old radios; the word "radial" means
> "extending in rays from a central point" and has nothing to do with radio
> buttons.
yes, too late
> - Is it safe to use memcpy? If not, is there a similar function I can use?
safeness comes from the way how you use it (don't overrun buffers etc).
Apart from that memcpy is ansi-C and pretty portable. Maybe you look at
similar code within the plugins first and check how its done there,
otherwise there is no much reason not to use memcpy (maybe we want to
favor C++ std::copy?)
Christian
_______________________________________________
Cinelerra mailing list
[email protected]
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
