Changeset: b41c0821948e for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/b41c0821948e
Modified Files:
sql/backends/monet5/rel_physical.c
sql/test/BugTracker-2026/Tests/All
Branch: default
Log Message:
small cleanup
diffs (36 lines):
diff --git a/sql/backends/monet5/rel_physical.c
b/sql/backends/monet5/rel_physical.c
--- a/sql/backends/monet5/rel_physical.c
+++ b/sql/backends/monet5/rel_physical.c
@@ -818,10 +818,9 @@ rel_pipeline(visitor *v, sql_rel *rel, b
}
} else if (is_topn(rel->op)) {
/* e.g. pp is not useful for "SELECT 42 LIMIT 2" */
- bool pp_useful = (get_rel_count(rel->l) > 1) && topn_limit(rel)
/*&& !(list_length(rel->exps) > 1)*/ /* no offset */;
- //pp_useful &= !rel->grouped; /* grouped topn isn't pipelined
yet */
+ bool pp_useful = (get_rel_count(rel->l) > 1) && topn_limit(rel)
/* no offset */;
/* op_topn always has rel->l */
- res = rel_pipeline(v, rel->l, pp_useful,
pp_useful?SPB/*:rel->grouped?0*/:0);
+ res = rel_pipeline(v, rel->l, pp_useful, pp_useful?SPB:0);
if (pp_useful && res) { /* topn is blocking */
rel->parallel = 1;
if (pb) { /* nested */
@@ -1596,7 +1595,6 @@ rel_push_down_topn(visitor *v, sql_rel *
nexps = append_func_argument(v, oe,
nexps);
append(pexps, oe);
} else {
- // assert (exp_is_useless_rename(oe) ||
(exp_is_rename(oe) && oe->nid != oe->alias.label));
append(nexps, oe);
append(pexps, exp_ref(v->sql, oe));
}
diff --git a/sql/test/BugTracker-2026/Tests/All
b/sql/test/BugTracker-2026/Tests/All
--- a/sql/test/BugTracker-2026/Tests/All
+++ b/sql/test/BugTracker-2026/Tests/All
@@ -183,7 +183,7 @@ KNOWNFAIL?7997-recursive-cte-number-over
KNOWNFAIL?7998-scalar-subquery-error-msg-improvement
7999-not-not-expr-bug
KNOWNFAIL?8000-select-count-distinct-assert-failure
-KNOWNFAIL?8001-select-count-where-having-bug
+8001-select-count-where-having-bug
KNOWNFAIL?8002-schema-renaming-makes-seq-invalid-bug
KNOWNFAIL?8003-windowed-group_concat-ignores-orderby-bug
KNOWNFAIL?8004-nth_value-windowfunction-bug
_______________________________________________
checkin-list mailing list -- [email protected]
To unsubscribe send an email to [email protected]
