Changeset: 9bb6f9520673 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/9bb6f9520673
Modified Files:
        sql/backends/monet5/sql_rank.c
        sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
Branch: Aug2024
Log Message:

Single value should return NULL always. Fixes #7588


diffs (31 lines):

diff --git a/sql/backends/monet5/sql_rank.c b/sql/backends/monet5/sql_rank.c
--- a/sql/backends/monet5/sql_rank.c
+++ b/sql/backends/monet5/sql_rank.c
@@ -1682,8 +1682,6 @@ do_stddev_and_variance(Client cntxt, Mal
                        msg = createException(SQL, op, GDK_EXCEPTION);
        } else {
                dbl *res = getArgReference_dbl(stk, pci, 0);
-               ValRecord *input1 = &(stk)->stk[(pci)->argv[1]];
-
                switch (tpe) {
                        case TYPE_bte:
                        case TYPE_sht:
@@ -1694,7 +1692,7 @@ do_stddev_and_variance(Client cntxt, Mal
 #endif
                        case TYPE_flt:
                        case TYPE_dbl:
-                               *res = VALisnil(input1) ? dbl_nil : 0;
+                               *res = dbl_nil;
                                break;
                        default:
                                msg = createException(SQL, op, SQLSTATE(42000) 
"%s not available for %s", op, ATOMname(tpe));
diff --git 
a/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test 
b/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
--- a/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
+++ b/sql/test/BugTracker-2024/Tests/bin_find_smallest_column-Bug-7482.test
@@ -1,5 +1,5 @@
 query R nosort
 SELECT var_samp ( '12' ) OVER ( ORDER BY CAST ( ( CASE WHEN ( 99 ) THEN COUNT 
( * ) ELSE CASE WHEN 1 THEN ( FALSE ) END END ) AS BIGINT ) )
 ----
-0.000
+NULL
 
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org

Reply via email to