Changeset: f3a38ec04a62 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/f3a38ec04a62
Modified Files:
        testing/sqltest.py
Branch: Aug2024
Log Message:

Use with statements.  This fixes a problem when using Python 3.13.


diffs (34 lines):

diff --git a/testing/sqltest.py b/testing/sqltest.py
--- a/testing/sqltest.py
+++ b/testing/sqltest.py
@@ -512,22 +512,19 @@ class PyMonetDBTestResult(TestCaseResult
                 self.query = query
                 crs = None
                 try:
-                    conn = self.test_case.conn_ctx.connect()
-                    crs = conn.cursor()
-                    crs.execute(query)
-                    self.rowcount = crs.rowcount
-                    self.rows = crs._rows
-                    if crs.description:
-                        self.data = crs.fetchall()
-                        self.description = crs.description
+                    with self.test_case.conn_ctx.connect() as conn, \
+                         conn.cursor() as crs:
+                        crs.execute(query)
+                        self.rowcount = crs.rowcount
+                        self.rows = crs._rows
+                        if crs.description:
+                            self.data = crs.fetchall()
+                            self.description = crs.description
                 except pymonetdb.Error as e:
                     self.test_run_error = e
                     self.err_code, self.err_message = 
self._parse_error(e.args[0])
                 except (OSError, ValueError) as e:
                     self.test_run_error = e
-                finally:
-                    if crs is not None:
-                        crs.close()
             self.did_run = True
         return self
 
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org

Reply via email to