Changeset: 1f5524bc8823 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/1f5524bc8823
Modified Files:
sql/backends/monet5/sql_bincopyconvert.c
Branch: Aug2024
Log Message:
Use slightly faster bat append function for binary copy-into of blobs.
diffs (34 lines):
diff --git a/sql/backends/monet5/sql_bincopyconvert.c
b/sql/backends/monet5/sql_bincopyconvert.c
--- a/sql/backends/monet5/sql_bincopyconvert.c
+++ b/sql/backends/monet5/sql_bincopyconvert.c
@@ -474,6 +474,12 @@ load_blob(BAT *bat, stream *s, int *eof_
*eof_reached = 0;
+ /* we know nothing about the ordering of the input data */
+ bat->tsorted = false;
+ bat->trevsorted = false;
+ bat->tkey = false;
+ /* keep tno* properties: if they're set they remain valid when
+ * appending */
while (1) {
const blob *value;
// Read the header
@@ -492,6 +498,8 @@ load_blob(BAT *bat, stream *s, int *eof_
if (header.length == ~(uint64_t)0) {
value = nil_value;
+ bat->tnonil = false;
+ bat->tnil = true;
} else {
size_t length;
size_t needed;
@@ -535,7 +543,7 @@ load_blob(BAT *bat, stream *s, int *eof_
value = buffer;
}
- if (BUNappend(bat, value, false) != GDK_SUCCEED) {
+ if (bunfastapp(bat, value) != GDK_SUCCEED) {
msg = createException(SQL, mal_operator,
GDK_EXCEPTION);
goto end;
}
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org
