Changeset: 6f59d6a8cd0e for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/6f59d6a8cd0e
Modified Files:
gdk/gdk_batop.c
Branch: Dec2023
Log Message:
Add some missing unlocks (in code that gets never executed, just for
completeness).
diffs (43 lines):
diff --git a/gdk/gdk_batop.c b/gdk/gdk_batop.c
--- a/gdk/gdk_batop.c
+++ b/gdk/gdk_batop.c
@@ -742,6 +742,7 @@ BATappend2(BAT *b, BAT *n, BAT *s, bool
atomcmp(BUNtail(ni, ni.minpos), minbound) < 0) {
assert(0);
GDKerror("value out of bounds\n");
+ MT_lock_unset(&b->theaplock);
goto bailout;
}
}
@@ -753,6 +754,7 @@ BATappend2(BAT *b, BAT *n, BAT *s, bool
atomcmp(BUNtail(ni, ni.maxpos), maxbound) >= 0) {
assert(0);
GDKerror("value out of bounds\n");
+ MT_lock_unset(&b->theaplock);
goto bailout;
}
}
@@ -805,6 +807,7 @@ BATappend2(BAT *b, BAT *n, BAT *s, bool
if (minbound && n->tseqbase + ci.seq - hseq <
*(const oid *)minbound) {
assert(0);
GDKerror("value not within bounds\n");
+ MT_lock_unset(&b->theaplock);
goto bailout;
}
BATtseqbase(b, n->tseqbase + ci.seq - hseq);
@@ -812,6 +815,7 @@ BATappend2(BAT *b, BAT *n, BAT *s, bool
if (maxbound && b->tseqbase + BATcount(b) + ci.ncand >=
*(const oid *)maxbound) {
assert(0);
GDKerror("value not within bounds\n");
+ MT_lock_unset(&b->theaplock);
goto bailout;
}
BATsetcount(b, BATcount(b) + ci.ncand);
@@ -824,6 +828,7 @@ BATappend2(BAT *b, BAT *n, BAT *s, bool
if (notnull) {
assert(0);
GDKerror("NULL value not within bounds\n");
+ MT_lock_unset(&b->theaplock);
goto bailout;
}
BATtseqbase(b, oid_nil);
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org
