Changeset: 5309c4e01182 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/5309c4e01182
Modified Files:
monetdb5/ChangeLog.Jul2021
monetdb5/mal/mal_session.c
Branch: Jul2021
Log Message:
Do not touch (and certainly not free) data after close.
diffs (27 lines):
diff --git a/monetdb5/ChangeLog.Jul2021 b/monetdb5/ChangeLog.Jul2021
--- a/monetdb5/ChangeLog.Jul2021
+++ b/monetdb5/ChangeLog.Jul2021
@@ -1,3 +1,9 @@
# ChangeLog file for MonetDB5
# This file is updated with Maddlog
+* Mon Apr 24 2023 Sjoerd Mullender <sjo...@acm.org>
+- A bug was fixed where data from a client context was freed after the
+ context was closed. This meant that the data being freed could belong
+ to the next user of the context (a next client that just connected),
+ leading to chaos (i.e. crashes).
+
diff --git a/monetdb5/mal/mal_session.c b/monetdb5/mal/mal_session.c
--- a/monetdb5/mal/mal_session.c
+++ b/monetdb5/mal/mal_session.c
@@ -536,10 +536,6 @@ MSserveClient(Client c)
*/
MCcloseClient(c);
- if (c->usermodule /*&& strcmp(c->usermodule->name, "user") == 0*/) {
- freeModule(c->usermodule);
- c->usermodule = NULL;
- }
return MAL_SUCCEED;
}
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org
