Changeset: 62208effe15d for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/62208effe15d
Modified Files:
        clients/odbc/driver/SQLSpecialColumns.c
Branch: Oct2020
Log Message:

Fix generated SQL in SQLSpecialColumns(). It missed a space.
Issue found using MS Query and the ODBC driver leading to error:

MSQRY32         3774-2fb4    EXIT  SQLSpecialColumnsW  with return code -1 
(SQL_ERROR)
        HSTMT               0x01D0E908
        UWORD                        1 <SQL_BEST_ROWID>
        WCHAR *             0x00000000 <null pointer>
        SWORD                       -3
        WCHAR *             0x003D43E0 [      -3] "sys\ 0"
        SWORD                       -3
        WCHAR *             0x01D0EF58 [      -3] "_tables\ 0"
        SWORD                       -3
        UWORD                        0 <SQL_SCOPE_CURROW>
        UWORD                        1 <SQL_NULLABLE>

        DIAG [42000] [MonetDB][ODBC Driver 11.39.17]syntax error, unexpected 
IDENT, expecting ')' in: "with sc as (select t.id as table_id, k.type as type, 
cast(1 as smallint) as scop" (0)


diffs (12 lines):

diff --git a/clients/odbc/driver/SQLSpecialColumns.c 
b/clients/odbc/driver/SQLSpecialColumns.c
--- a/clients/odbc/driver/SQLSpecialColumns.c
+++ b/clients/odbc/driver/SQLSpecialColumns.c
@@ -221,7 +221,7 @@ MNDBSpecialColumns(ODBCStmt *stmt,
                              "sys.tables t, "
                              "sys.columns c, "
                              "sys.keys k, "
-                             "sys.objects kc"
+                             "sys.objects kc "
                         "where s.id = t.schema_id and "
                               "t.id = c.table_id and "
                               "t.id = k.table_id and "
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list

Reply via email to