MonetDB: default - Names are generally read-only: getName/putNam...

Sjoerd Mullender Mon, 18 Jan 2021 09:57:11 -0800

Changeset: 0dd331b5e0b2 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=0dd331b5e0b2
Modified Files:
        clients/Tests/exports.stable.out
        monetdb5/mal/mal.h
        monetdb5/mal/mal_atom.c
        monetdb5/mal/mal_builder.c
        monetdb5/mal/mal_builder.h
        monetdb5/mal/mal_client.h
        monetdb5/mal/mal_debugger.c
        monetdb5/mal/mal_function.c
        monetdb5/mal/mal_function.h
        monetdb5/mal/mal_import.c
        monetdb5/mal/mal_import.h
        monetdb5/mal/mal_instruction.c
        monetdb5/mal/mal_instruction.h
        monetdb5/mal/mal_module.c
        monetdb5/mal/mal_module.h
        monetdb5/mal/mal_namespace.c
        monetdb5/mal/mal_namespace.h
        monetdb5/mal/mal_parser.c
        monetdb5/mal/mal_prelude.c
        monetdb5/mal/mal_private.h
        monetdb5/mal/mal_profiler.c
        monetdb5/mal/mal_session.c
        monetdb5/mal/mel.h
        monetdb5/modules/mal/language.c
        monetdb5/modules/mal/oltp.c
        monetdb5/optimizer/opt_bincopyfrom.c
        monetdb5/optimizer/opt_coercion.c
        monetdb5/optimizer/opt_generator.c
        monetdb5/optimizer/opt_multiplex.c
        monetdb5/optimizer/opt_parappend.c
        monetdb5/optimizer/opt_prelude.c
        monetdb5/optimizer/opt_prelude.h
        monetdb5/optimizer/opt_remap.c
        monetdb5/scheduler/run_memo.c
        sql/backends/monet5/sql_gencode.c
        sql/backends/monet5/sql_scenario.c
        sql/backends/monet5/sql_scenario.h
        sql/backends/monet5/sql_statement.c
        sql/common/sql_backend.c
        sql/common/sql_backend.h
        sql/server/sql_qc.c
        sql/server/sql_qc.h
Branch: default
Log Message:


Names are generally read-only: getName/putName return const char *.
This means that all *Ref variables are also const char * and some more
variables and function arguments have been changed to const char *.


diffs (truncated from 2926 to 300 lines):

diff --git a/clients/Tests/exports.stable.out b/clients/Tests/exports.stable.out
--- a/clients/Tests/exports.stable.out
+++ b/clients/Tests/exports.stable.out
@@ -1033,76 +1033,76 @@ str WLCstop(Client cntxt, MalBlkPtr mb, 
 str WLCtransaction(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci);
 str WLCupdate(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci);
 int WLCused(void);
-str abortRef;
-str actionRef;
+const char *abortRef;
+const char *actionRef;
 InstrPtr addArgument(MalBlkPtr mb, InstrPtr p, int varid);
 void addMalException(MalBlkPtr mb, str msg);
 str addOptimizerPipe(Client cntxt, MalBlkPtr mb, const char *name);
 str addPipeDefinition(Client cntxt, const char *name, const char *pipe);
 void addtoMalBlkHistory(MalBlkPtr mb);
-str affectedRowsRef;
-str aggrRef;
-str alarmRef;
-str algebraRef;
-str alter_add_range_partitionRef;
-str alter_add_tableRef;
-str alter_add_value_partitionRef;
-str alter_constraintRef;
-str alter_del_tableRef;
-str alter_functionRef;
-str alter_indexRef;
-str alter_roleRef;
-str alter_schemaRef;
-str alter_seqRef;
-str alter_set_tableRef;
-str alter_tableRef;
-str alter_triggerRef;
-str alter_typeRef;
-str alter_userRef;
-str alter_viewRef;
-str andRef;
-str appendBulkRef;
-str appendRef;
-str append_execRef;
-str append_finishRef;
-str append_prepRef;
-str appendidxRef;
-str arrayRef;
-str assertRef;
-str attachRef;
-str avgRef;
-str bandjoinRef;
-str basketRef;
+const char *affectedRowsRef;
+const char *aggrRef;
+const char *alarmRef;
+const char *algebraRef;
+const char *alter_add_range_partitionRef;
+const char *alter_add_tableRef;
+const char *alter_add_value_partitionRef;
+const char *alter_constraintRef;
+const char *alter_del_tableRef;
+const char *alter_functionRef;
+const char *alter_indexRef;
+const char *alter_roleRef;
+const char *alter_schemaRef;
+const char *alter_seqRef;
+const char *alter_set_tableRef;
+const char *alter_tableRef;
+const char *alter_triggerRef;
+const char *alter_typeRef;
+const char *alter_userRef;
+const char *alter_viewRef;
+const char *andRef;
+const char *appendBulkRef;
+const char *appendRef;
+const char *append_execRef;
+const char *append_finishRef;
+const char *append_prepRef;
+const char *appendidxRef;
+const char *arrayRef;
+const char *assertRef;
+const char *attachRef;
+const char *avgRef;
+const char *bandjoinRef;
+const char *basketRef;
 void batAfterCall(ValPtr v, ValPtr bak);
 void batBeforeCall(ValPtr v, ValPtr bak);
-str batRef;
-str batalgebraRef;
-str batcalcRef;
-str batcapiRef;
-str batmalRef;
-str batmmathRef;
-str batmtimeRef;
-str batpyapi3Ref;
-str batrapiRef;
-str batsqlRef;
-str batstrRef;
+const char *batRef;
+const char *batalgebraRef;
+const char *batcalcRef;
+const char *batcapiRef;
+const char *batmalRef;
+const char *batmmathRef;
+const char *batmtimeRef;
+const char *batpyapi3Ref;
+const char *batrapiRef;
+const char *batsqlRef;
+const char *batstrRef;
 bool batstr_func_has_candidates(const char *func);
-str batxmlRef;
-str bbpRef;
-str betweenRef;
-str bindRef;
-str binddbatRef;
-str bindidxRef;
+const char *batxmlRef;
+const char *bbpRef;
+const char *betweenRef;
+const char *bindRef;
+const char *binddbatRef;
+const char *bindidxRef;
 var_t blobsize(size_t nitems);
-str blockRef;
-str bpmRef;
-str bstreamRef;
-str bulk_rotate_xor_hashRef;
-str calcRef;
+const char *blockRef;
+const char *bpmRef;
+const char *bstreamRef;
+const char *bulk_rotate_xor_hashRef;
+const char *calcRef;
 str callMAL(Client cntxt, MalBlkPtr mb, MalStkPtr *glb, ValPtr argv[], char 
debug);
 str callString(Client c, str s, int listing);
-str capiRef;
-str catalogRef;
+const char *capiRef;
+const char *catalogRef;
 str chkDeclarations(MalBlkPtr mb);
 str chkFlow(MalBlkPtr mb);
 int chkInstruction(Module s, MalBlkPtr mb, InstrPtr p);
@@ -1111,101 +1111,101 @@ str chkTypes(Module s, MalBlkPtr mb, int
 str cleanupTraces(Client cntxt);
 void clearTrace(Client cntxt);
 void clearVariable(MalBlkPtr mb, int varid);
-str clear_tableRef;
+const char *clear_tableRef;
 int cloneVariable(MalBlkPtr dst, MalBlkPtr src, int varid);
 str closeProfilerStream(Client cntxt);
-str closeRef;
+const char *closeRef;
 void clrDeclarations(MalBlkPtr mb);
 void clrFunction(InstrPtr p);
 void clrInstruction(InstrPtr p);
-str columnBindRef;
-str columnRef;
-str comment_onRef;
-str commitRef;
+const char *columnBindRef;
+const char *columnRef;
+const char *comment_onRef;
+const char *commitRef;
 str compileAllOptimizers(Client cntxt);
 str compileOptimizer(Client cntxt, const char *name);
 str compileString(Symbol *fcn, Client c, str s);
-str connectRef;
-str contextRef;
+const char *connectRef;
+const char *contextRef;
 str convertConstant(malType type, ValPtr vr);
 InstrPtr copyInstruction(InstrPtr p);
 InstrPtr copyInstructionArgs(InstrPtr p, int args);
 MalBlkPtr copyMalBlk(MalBlkPtr mb);
-str copyRef;
-str copy_fromRef;
-str countRef;
-str count_no_nilRef;
+const char *copyRef;
+const char *copy_fromRef;
+const char *countRef;
+const char *count_no_nilRef;
 int cpyConstant(MalBlkPtr mb, VarPtr vr);
 str createException(enum malexception, const char *, _In_z_ 
_Printf_format_string_ const char *, ...) __attribute__((__format__(__printf__, 
3, 4))) __attribute__((__returns_nonnull__));
 str createMalException(MalBlkPtr, int, enum malexception, _In_z_ 
_Printf_format_string_ const char *, ...) __attribute__((__format__(__printf__, 
4, 5))) __attribute__((__returns_nonnull__));
-str createRef;
-str create_constraintRef;
-str create_functionRef;
-str create_indexRef;
-str create_roleRef;
-str create_schemaRef;
-str create_seqRef;
-str create_tableRef;
-str create_triggerRef;
-str create_typeRef;
-str create_userRef;
-str create_viewRef;
-str crossRef;
-str cume_distRef;
-str dataflowRef;
-str dateRef;
-str dblRef;
+const char *createRef;
+const char *create_constraintRef;
+const char *create_functionRef;
+const char *create_indexRef;
+const char *create_roleRef;
+const char *create_schemaRef;
+const char *create_seqRef;
+const char *create_tableRef;
+const char *create_triggerRef;
+const char *create_typeRef;
+const char *create_userRef;
+const char *create_viewRef;
+const char *crossRef;
+const char *cume_distRef;
+const char *dataflowRef;
+const char *dateRef;
+const char *dblRef;
 str deblockdataflow(Client cntxt, MalBlkPtr mb, MalStkPtr stk, InstrPtr pci);
 void debugFunction(stream *fd, MalBlkPtr mb, MalStkPtr stk, int flg, int 
first, int size);
 int defConstant(MalBlkPtr mb, int type, ValPtr cst);
-str defineRef;
+const char *defineRef;
 void delArgument(InstrPtr p, int varid);
 void delName(const char *nme, size_t len);
-str deleteRef;
+const char *deleteRef;
 void deleteSymbol(Module scope, Symbol prg);
-str deltaRef;
-str dense_rankRef;
+const char *deltaRef;
+const char *dense_rankRef;
 malType destinationType(MalBlkPtr mb, InstrPtr p);
-str diffRef;
-str diffcandRef;
-str differenceRef;
-str disconnectRef;
-str divRef;
-str drop_constraintRef;
-str drop_functionRef;
-str drop_indexRef;
-str drop_roleRef;
-str drop_schemaRef;
-str drop_seqRef;
-str drop_tableRef;
-str drop_triggerRef;
-str drop_typeRef;
-str drop_userRef;
-str drop_viewRef;
+const char *diffRef;
+const char *diffcandRef;
+const char *differenceRef;
+const char *disconnectRef;
+const char *divRef;
+const char *drop_constraintRef;
+const char *drop_functionRef;
+const char *drop_indexRef;
+const char *drop_roleRef;
+const char *drop_schemaRef;
+const char *drop_seqRef;
+const char *drop_tableRef;
+const char *drop_triggerRef;
+const char *drop_typeRef;
+const char *drop_userRef;
+const char *drop_viewRef;
 void dumpModules(stream *out);
-str emptybindRef;
-str emptybindidxRef;
-str eqRef;
+const char *emptybindRef;
+const char *emptybindidxRef;
+const char *eqRef;
 str evalFile(str fname, int listing);
-str evalRef;
-str execRef;
-str expandRef;
-str exportOperationRef;
-str export_tableRef;
+const char *evalRef;
+const char *execRef;
+const char *expandRef;
+const char *exportOperationRef;
+const char *export_tableRef;
 str fcnDefinition(MalBlkPtr mb, InstrPtr p, str s, int flg, str base, size_t 
len);
-str fetchRef;
+const char *fetchRef;
 int findGDKtype(int type);
 Module findModule(Module scope, const char *name);
-str findRef;
+const char *findRef;
 Scenario findScenario(str nme);
 Symbol findSymbol(Module usermodule, const char *mod, const char *fcn);
 Symbol findSymbolInModule(Module v, const char *fcn);
 int findVariable(MalBlkPtr mb, const char *name);
-int findVariableLength(MalBlkPtr mb, str name, int len);
-str finishRef;
-str first_valueRef;
-str firstnRef;
-Module fixModule(str nme);
+int findVariableLength(MalBlkPtr mb, const char *name, int len);
+const char *finishRef;
+const char *first_valueRef;
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list

MonetDB: default - Names are generally read-only: getName/putNam...

Reply via email to