Changeset: 741f5675b8b6 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=741f5675b8b6
Modified Files:
        sql/backends/monet5/UDF/capi/capi.c
        sql/backends/monet5/rel_bin.c
Branch: Nov2019
Log Message:

Merge with Apr2019 branch.


diffs (42 lines):

diff --git a/sql/backends/monet5/UDF/capi/capi.c 
b/sql/backends/monet5/UDF/capi/capi.c
--- a/sql/backends/monet5/UDF/capi/capi.c
+++ b/sql/backends/monet5/UDF/capi/capi.c
@@ -659,7 +659,7 @@ static str CUDFeval(Client cntxt, MalBlk
                                i + 1 - prefix_size);
                memcpy(buf + prefix_size, SO_PREFIX, sizeof(char) * 
strlen(SO_PREFIX));
                path =
-                       GDKfilepath(0, BATDIR, buf, SO_EXT[0] == '.' ? SO_EXT + 
1 : SO_EXT);
+                       GDKfilepath(0, BATDIR, buf, SO_EXT[0] == '.' ? 
&SO_EXT[1] : SO_EXT);
                if (!path) {
                        msg = createException(MAL, "cudf.eval", 
MAL_MALLOC_FAIL);
                        goto wrapup;
diff --git a/sql/backends/monet5/rel_bin.c b/sql/backends/monet5/rel_bin.c
--- a/sql/backends/monet5/rel_bin.c
+++ b/sql/backends/monet5/rel_bin.c
@@ -565,7 +565,6 @@ exp_bin(backend *be, sql_exp *e, stmt *l
        }       break;
        case e_convert: {
                /* if input is type any NULL or column of nulls, change type */
-               sql_exp *ll = (sql_exp *) e->l;
                list *tps = e->r;
                sql_subtype *from = tps->h->data;
                sql_subtype *to = tps->h->next->data;
@@ -574,16 +573,11 @@ exp_bin(backend *be, sql_exp *e, stmt *l
                if (from->type->localtype == 0) {
                        l = stmt_atom(be, atom_general(sql->sa, to, NULL));
                } else {
-                       l = exp_bin(be, ll, left, right, grp, ext, cnt, sel);
+                       l = exp_bin(be, e->l, left, right, grp, ext, cnt, sel);
                }
                if (!l)
                        return NULL;
-               /* if attempting to convert between strings, no conversion is 
needed */
-               if (ll->type == e_column && EC_VARCHAR(from->type->eclass) && 
EC_VARCHAR(to->type->eclass)) {
-                       s = l;
-               } else {
-                       s = stmt_convert(be, l, from, to, sel);
-               }
+               s = stmt_convert(be, l, from, to, sel);
        }       break;
        case e_func: {
                node *en;
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list

Reply via email to