Changeset: 75a5b5754020 for monetdb-java
URL: https://dev.monetdb.org/hg/monetdb-java?cmd=changeset;node=75a5b5754020
Modified Files:
        ChangeLog
        src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
Branch: default
Log Message:

Correction: Loader functions (type = 7) should return a table.


diffs (28 lines):

diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -18,9 +18,9 @@
 * Thu Apr 19 2018 Martin van Dinther <martin.van.dint...@monetdbsolutions.com>
 - Corrected method DatabaseMetaData.getFunctions() for result column
   FUNCTION_TYPE.  It used to return DatabaseMetaData.functionResultUnknown
-  value for when the internal function type was 6 (Analytic function) or 7
-  (Loader function).  It now returns DatabaseMetaData.functionNoTable value
-  for those function types.
+  value for Analytic (functions.type 6) and Loader function (functions type 7).
+  It now returns DatabaseMetaData.functionNoTable for Analytic functions and
+  DatabaseMetaData.functionReturnsTable for Loader functions.
 - DatabaseMetaData methods getTables(), getColumns(), getProcedures() and
   getFunctions() now return the comment in the REMARKS result column when a
   comment has been set for the table / view / column / procedure / function
diff --git a/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java 
b/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
--- a/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
+++ b/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
@@ -3928,7 +3928,7 @@ public class MonetDatabaseMetaData exten
                        .append(" WHEN 4 THEN 
").append(DatabaseMetaData.functionNoTable)
                        .append(" WHEN 5 THEN 
").append(DatabaseMetaData.functionReturnsTable)
                        .append(" WHEN 6 THEN 
").append(DatabaseMetaData.functionNoTable)
-                       .append(" WHEN 7 THEN 
").append(DatabaseMetaData.functionNoTable)
+                       .append(" WHEN 7 THEN 
").append(DatabaseMetaData.functionReturnsTable)
                        .append(" ELSE 
").append(DatabaseMetaData.functionResultUnknown).append(" END AS 
\"FUNCTION_TYPE\", " +
                        // only the id value uniquely identifies a function. 
Include it to be able to differentiate between multiple overloaded functions 
with the same name
                        "cast(\"functions\".\"id\" as varchar(10)) AS 
\"SPECIFIC_NAME\" " +
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list

Reply via email to