Changeset: 06e48fbc996d for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=06e48fbc996d Modified Files: java/src/main/java/nl/cwi/monetdb/util/CmdLineOpts.java java/src/main/java/nl/cwi/monetdb/util/OptionsException.java Branch: default Log Message:
Resolving javac -Xlint warnings: ./nl/cwi/monetdb/util/CmdLineOpts.java:115: warning: [cast] redundant cast to CmdLineOpts.OptionContainer option = (OptionContainer)(opts.get(tmp)); ^ ./nl/cwi/monetdb/util/CmdLineOpts.java:118: warning: [cast] redundant cast to CmdLineOpts.OptionContainer option = (OptionContainer)(opts.get(tmp.substring(0, pos))); ^ ./nl/cwi/monetdb/util/CmdLineOpts.java:129: warning: [cast] redundant cast to CmdLineOpts.OptionContainer option = (OptionContainer)(opts.get(tmp)); ^ ./nl/cwi/monetdb/util/CmdLineOpts.java:132: warning: [cast] redundant cast to CmdLineOpts.OptionContainer option = (OptionContainer)(opts.get(tmp.substring(0, pos))); ^ ./nl/cwi/monetdb/util/CmdLineOpts.java:140: warning: [cast] redundant cast to CmdLineOpts.OptionContainer option = (OptionContainer)(opts.get("" + args[i].charAt(1))); ^ ./nl/cwi/monetdb/util/OptionsException.java:11: warning: [serial] serializable class OptionsException has no definition of serialVersionUID public class OptionsException extends Exception { ^ 6 warnings diffs (59 lines): diff --git a/java/src/main/java/nl/cwi/monetdb/util/CmdLineOpts.java b/java/src/main/java/nl/cwi/monetdb/util/CmdLineOpts.java --- a/java/src/main/java/nl/cwi/monetdb/util/CmdLineOpts.java +++ b/java/src/main/java/nl/cwi/monetdb/util/CmdLineOpts.java @@ -112,10 +112,10 @@ public class CmdLineOpts { String tmp = args[i].substring(2); int pos = tmp.indexOf('='); if (pos == -1) { - option = (OptionContainer)(opts.get(tmp)); + option = opts.get(tmp); moreData = false; } else { - option = (OptionContainer)(opts.get(tmp.substring(0, pos))); + option = opts.get(tmp.substring(0, pos)); // modify the option a bit so the code below // handles the moreData correctly args[i] = "-?" + tmp.substring(pos + 1); @@ -126,10 +126,10 @@ public class CmdLineOpts { String tmp = args[i].substring(1); int pos = tmp.indexOf('='); if (pos == -1) { - option = (OptionContainer)(opts.get(tmp)); + option = opts.get(tmp); moreData = false; } else { - option = (OptionContainer)(opts.get(tmp.substring(0, pos))); + option = opts.get(tmp.substring(0, pos)); // modify the option a bit so the code below // handles the moreData correctly args[i] = "-?" + tmp.substring(pos + 1); @@ -137,7 +137,7 @@ public class CmdLineOpts { } } else { // single char argument - option = (OptionContainer)(opts.get("" + args[i].charAt(1))); + option = opts.get("" + args[i].charAt(1)); // is there more data left in the argument? moreData = args[i].length() > 2 ? true : false; } @@ -288,7 +288,7 @@ public class CmdLineOpts { boolean present; public OptionContainer( - String shorta, + String shorta, String longa, int cardinality, String defaulta, diff --git a/java/src/main/java/nl/cwi/monetdb/util/OptionsException.java b/java/src/main/java/nl/cwi/monetdb/util/OptionsException.java --- a/java/src/main/java/nl/cwi/monetdb/util/OptionsException.java +++ b/java/src/main/java/nl/cwi/monetdb/util/OptionsException.java @@ -9,6 +9,8 @@ package nl.cwi.monetdb.util; public class OptionsException extends Exception { + static final long serialVersionUID = 42L; // needed to prevent: warning: [serial] serializable class OptionsException has no definition of serialVersionUID + public OptionsException(String reason) { super(reason); } _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list